Skip to content

Emit the new code and push corresponding fixes.#59346

Merged
nick863 merged 4 commits into
mainfrom
nirovins/emit_new_code
May 22, 2026
Merged

Emit the new code and push corresponding fixes.#59346
nick863 merged 4 commits into
mainfrom
nirovins/emit_new_code

Conversation

@nick863
Copy link
Copy Markdown
Member

@nick863 nick863 commented May 19, 2026

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@nick863 nick863 marked this pull request as ready for review May 20, 2026 00:29
Copilot AI review requested due to automatic review settings May 20, 2026 00:29
@nick863 nick863 requested review from a team, glharper, jsquire, trangevi and trrwilson as code owners May 20, 2026 00:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copy link
Copy Markdown
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baselines look good, based on our conversation about them being experimental. Let's pull @m-nash in for architect perspective as well. Once you've got team sign-off, mention me and I'll do a final pass and merge.

@jsquire jsquire requested a review from m-nash May 20, 2026 00:33
Comment thread eng/apicompatbaselines/Azure.AI.Extensions.OpenAI.txt Outdated
Copy link
Copy Markdown
Member

@m-nash m-nash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for beta release.

Before we GA we will need to catch up on marking all the experimental classes with their ExperimentalAttribute.

@nick863 nick863 merged commit ddd99c2 into main May 22, 2026
22 checks passed
@nick863 nick863 deleted the nirovins/emit_new_code branch May 22, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants